DOC-1380: Deletion of expired transaction markers#1551
DOC-1380: Deletion of expired transaction markers#1551
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis PR updates documentation across two Redpanda files to describe the transactional control batch removal feature during log compaction. The changes clarify that Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@modules/manage/pages/cluster-maintenance/compaction-settings.adoc`:
- Around line 159-175: Add the Tiered Storage limitation to the transactional
control batch removal docs: update the existing NOTE block under Transactional
control batch removal to include a sentence stating that "This feature is not
applied when Tiered Storage is enabled." Reference the relevant property names
(log_compaction_tx_batch_removal_enabled and delete.retention.ms) remain
unchanged; simply append the Tiered Storage limitation to the NOTE or add a
short paragraph immediately after it so the docs match the transactions.adoc
behavior.
🧹 Nitpick comments (1)
modules/develop/pages/transactions.adoc (1)
328-329: Consider using empty brackets for xref to auto-pull section title.The xref to the compaction settings page includes explicit link text. Per documentation best practices, consider using empty brackets to automatically pull the section title from the target document:
-See xref:manage:cluster-maintenance/compaction-settings.adoc#transactional-control-batch-removal[Transactional control batch removal]. +See xref:manage:cluster-maintenance/compaction-settings.adoc#transactional-control-batch-removal[].This ensures the link text stays synchronized if the target section title changes.
Based on learnings, this applies to all AsciiDoc files in the repository.
WillemKauf
left a comment
WillemKauf
left a comment
There was a problem hiding this comment.
Looks great! No notes.
|
@WillemKauf we had this separate ticket that this may hit Cloud. Can you please confirm if this impacts Cloud docs at all? |
No, we shouldn't make mention of this in cloud docs. |
modules/manage/pages/cluster-maintenance/compaction-settings.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Michele Cyran <[email protected]>
|
@paulohtb6: It'd be nice if |
3 participants
Description
Clarifies the relationship of the newly introduced property
log_compaction_tx_batch_removal_enabledand the existing behavior ofdeletion.retention.msResolves https://redpandadata.atlassian.net/browse/DOC-1380
Review deadline: Jan 26th
Page previews
Checks